Author Topic: Grand Crusade Possible fixes for lucky, plunder and la vie en rose  (Read 92 times)

Offline NIIcK

  • Knight
  • ***
  • Posts: 56
Possible fixes for lucky, plunder and la vie en rose
« on: March 08, 2019, 12:29:09 PM »
Tested on Grand Crusade!

- implementation for Lucky clover effect based on the character luck
- implementation for plunder skills and added the 105-110
- implementation for la vie en rose section for merchant of mammon

Please confirm/infirm.

Diff file: -removed-

Online Sdw-

  • Elder
  • ****
  • Posts: 143
Re: Possible fixes for lucky, plunder and la vie en rose
« Reply #1 on: March 08, 2019, 08:37:08 PM »
Infirming

Online Mobius

  • Administrator
  • Distinguished King
  • *****
  • Posts: 4945
Re: Possible fixes for lucky, plunder and la vie en rose
« Reply #2 on: March 10, 2019, 11:58:48 AM »
Got some idea on why you made this.
But patch is unusable.

Patch code style format differs project style, a lot. Making diff hard to read / see what has changed.
Checkout the project as described in my guide, then make a patch only for what you want to share.
Patch removed.

Also separate shares should have separate posts.

Online Mobius

  • Administrator
  • Distinguished King
  • *****
  • Posts: 4945
Re: Possible fixes for lucky, plunder and la vie en rose
« Reply #3 on: March 10, 2019, 02:37:34 PM »
I made some improvements on my own for the current plunder skill with revision 4977.
Skill level changes committed with revision 4978.